Merged
Conversation
koesie10
reviewed
Nov 11, 2022
koesie10
approved these changes
Nov 11, 2022
Contributor
|
|
Contributor
Author
My plan/hope is to eventually move away from the term "pure" as it's a little bit confusing (makes me think of pure functions) and have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, classes/modules that interact with events (raising or catching) have to import Event/EventEmitter which couples them to the VS Code API and as a consequence it means we're no longer able to write unit tests. It pushes us towards writing slow integration tests that require the whole extension host.
This PR introduces some custom abstractions that we can use instead of bringing in the VS Code API.
Checklist
N/A:
ready-for-doc-reviewlabel there.